Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: router #19

Merged
merged 1 commit into from
Jan 16, 2017
Merged

fix: router #19

merged 1 commit into from
Jan 16, 2017

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Jan 16, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 merged commit 0e1aeba into master Jan 16, 2017
@atian25 atian25 deleted the url branch January 16, 2017 09:35
fengmk2
fengmk2 reviewed Jan 16, 2017
View reviewed changes
boilerplate/app/router.js
@@ -1,5 +1,5 @@
'use strict';

module.exports = app => {
app.get('/home', 'home');
app.get('/', 'home');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

呃，你应该兼容一下，要不然又要去改手册。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atian25 @fengmk2